Repository navigation
Improve handling a datetime field in a sub-type - #113
Merged
Merged
Conversation
Update test to use JsonSubtypes converter
Owner
|
Hello, The issue should apparently not have been solved in this library, if you want the deserialization to happen as you expect you should deserialize with that settings; var obj = JsonConvert.DeserializeObject<MainClass>(json, new JsonSerializerSettings
{
DateParseHandling = DateParseHandling.DateTimeOffset
});The way it has been solved cause #120 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into an issue where a subtype containing a date field was not deserialised correctly (it appeared that the timezone of the date was changed to my local machine's timezone). This is an attempt at a fix based on a workaround I found for this issue, but would appreciate it if there was a better solution.